[1/2] Swift Concurrency migration - Financial Connections API client #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 builds increased size, 6 builds had no size change
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Swift._NativeDictionary.merge(isUnique,uniquingKeysWith) | ⬆️ 4.4 kB |
| Code Signature | ⬆️ 4.2 kB |
| 🗑 StripeFinancialConnections.NativeFlowAPIDataManager.manifest | ⬇️ -2.0 kB |
| StripeFinancialConnections.NativeFlowAPIDataManager.init(manifest... | ⬇️ -1.8 kB |
| StripeFinancialConnectionsSize | ⬆️ 1.3 kB |
View Treemap
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 193.3 kB (3.88%)
Total download size change: ⬆️ 67.6 kB (4.34%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Code Signature | ⬆️ 5.0 kB |
| Swift._NativeDictionary.merge(isUnique,uniquingKeysWith) | ⬆️ 4.4 kB |
| 🗑 StripeFinancialConnections.NativeFlowAPIDataManager.manifest | ⬇️ -2.0 kB |
| StripeFinancialConnections.NativeFlowAPIDataManager.init(manifest... | ⬇️ -1.8 kB |
| StripeConnectSize | ⬆️ 1.3 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
|
🚨 New dead code detected in this PR: FinancialConnectionsAsyncAPIClient.swift:169 warning: Protocol 'FinancialConnectionsAsyncAPI' is redundant as it's never used as an existential type
FinancialConnectionsAsyncAPIClient.swift:348 warning: Protocol 'FinancialConnectionsAsyncAPI' conformance is redundantPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mats-stripe
changed the title
mats-stripe
changed the title
mats-stripe
force-pushed
the
mats/async_fc_api_client
branch
from
0da754c to
70bd939
Compare
mats-stripe
force-pushed
the
mats/async_fc_api_client
branch
from
323a063 to
0e1c5f1
Compare
| @@ -426,6 +441,11 @@ private func PresentFinancialConnectionsSheet( | |||
| ) | |||
| financialConnectionsSheet.apiClient.stripeAccount = stripeAccount | |||
| financialConnectionsSheet.onEvent = onEvent | |||
|
|
|||
| let elementsSessionContext = StripeCore.ElementsSessionContext( | |||
| usesExperimentalAsyncAPIClient: useAsyncApiClient | |||
There was a problem hiding this comment.
I’m not sure that we want to have this in ElementsSessionContext. Can we stuff it in UserDefaults while we’re testing everything? That makes it easy to rip out again once we fully migrate over.
There was a problem hiding this comment.
I could do that!
mats-stripe
force-pushed
the
mats/async_fc_api_client
branch
from
0e1c5f1 to
8b24b2d
Compare
mats-stripe
force-pushed
the
mats/async_fc_api_client
branch
from
8b24b2d to
b81d579
Compare
| @@ -301,6 +303,12 @@ protocol FinancialConnectionsAPI { | |||
| paymentDetailsId: String, | |||
| billingDetails: ElementsSessionContext.BillingDetails? | |||
| ) -> Future<LinkBankPaymentMethod> | |||
|
|
|||
| func updateAvailableIncentives( | |||
tillh-stripe
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new Swift Concurrency based API client to the Financial Connections SDK, laying the groundwork for an eventual full migration. The changes are implemented in a way that allows for a gradual rollout without disrupting existing functionality. To do this, we introduce;
FinancialConnectionsAsyncAPIClient: A new API client fully powered by Swift Concurrency.Some implementation details:
FinancialConnectionsAPIprotocol, maintaining the current interface for API client consumers throughout the SDK.This work also provides a shape for the new async API. The current API is shaped as:
While the new API is shaped as:
A toggle has been added to the FC example app to switch between API client implementations. This is currently the only way to test the async API client:
Motivation
Move towards migration to Swift Concurrency
Next Steps: Part 2 will focus on migrating existing consumers to use the new async API client.
Testing
Unit tests added, and manual testing done.
Screen.Recording.2025-01-08.at.1.47.18.PM.mov
Changelog
N/a